config/network: Also change the link to supervise symlink #848
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the section talking about interface-specific dhcpcd, the run script is modified with sed to have the proper interface name, but there is also the supervise symlink, pointing into /run/runit. The target is "supervise.dhcpcd-eth0", which kind of works as-is, until you also have an actual eth0 interface that is handled by a dhcpcd supervised by runit. So to avoid having this misleading symlink, change it to a proper target: "supervise.dhcpcd-enp3s0" in the sample code. Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
vincele
changed the title
|
And just after creating the PR, I see the related #839, which is another take on the same subject... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the section talking about interface-specific dhcpcd, the run script is modified with sed to have the proper interface name, but there is also the supervise symlink, pointing into /run/runit.
The target is "supervise.dhcpcd-eth0", which kind of works as-is, until you also have an actual eth0 interface that is handled by a dhcpcd supervised by runit.
So to avoid having this misleading symlink, change it to a proper target: "supervise.dhcpcd-enp3s0" in the sample code.