Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with input file audio path format selection (gui.py) #602

Closed
sbersier opened this issue May 10, 2023 · 8 comments · Fixed by #1159
Closed

Problem with input file audio path format selection (gui.py) #602

sbersier opened this issue May 10, 2023 · 8 comments · Fixed by #1159
Labels
bug Something isn't working

Comments

@sbersier
Copy link

SVC version: 3.14.1

Currently, format selection for the input audio path file doesn't allow for format selection and filter shows no audio files.

The problem is on line 352 of gui.py

I solved it by putting, on line 352:
file_types=get_supported_file_types(),

instead of the current:

file_types=get_supported_file_types_concat(),

This solved the problem for me. See before and after videos.
Before:

before.mp4

After correction:

after.mp4
@sbersier sbersier added the bug Something isn't working label May 10, 2023
@34j
Copy link
Collaborator

34j commented May 10, 2023 •
edited
Loading

Another issue due to the different behavior between Linux and Windows 😇

@34j
Copy link
Collaborator

34j commented May 10, 2023 

if os.environ("OS") == "nt"...

@sbersier
Copy link
Author

NOTE: My installed version on PySimpleGui is: 4.60.4
Do you have a more recent version?

@34j
Copy link
Collaborator

34j commented May 10, 2023 •
edited
Loading

I think it's an OS-related problem, not PySimpleGUI

@sbersier
Copy link
Author

Another problem... The checkboxes change when pressing on "infer"...
It only appears at first inference. The second time you press on "infer", that's good. :-D

other.mp4

@34j
Copy link
Collaborator

34j commented May 11, 2023

Another problem... The checkboxes change when pressing on "infer"... It only appears at first inference. The second time you press on "infer", that's good. :-D

other.mp4

#95

@34j
Copy link
Collaborator

34j commented May 11, 2023 •
edited
Loading

Bug reports are appreciated, but note that you can also send PRs. 😴

@sbersier
Copy link
Author

I have never sent a pull request. I have no idea about how it works, but I'll try to see if I can figure it out...

@sbersier sbersier reopened this May 11, 2023
@upColor upColor mentioned this issue May 28, 2023
Open
2 tasks
baptisterajaut added a commit to baptisterajaut/so-vits-svc-fork that referenced this issue Apr 10, 2024
@baptisterajaut
Fix voicepaw#602
a1e42ef 
Add a basic platform check.
@baptisterajaut baptisterajaut mentioned this issue Apr 10, 2024
Merged
8 tasks
@34j 34j closed this as completed in #1159 May 10, 2024
34j added a commit that referenced this issue May 10, 2024
@baptisterajaut @pre-commit-ci @34j
fix(gui): fix format selection for the input audio in non-Windows (#1159
8168cb4 
)

* Fix #602

Add a basic platform check.

* chore(pre-commit.ci): auto fixes

* fix(gui): fix format selection for the input audio in non-windows

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: 34j <55338215+34j@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(gui): fix format selection for the input audio in non-Windows baptisterajaut/so-vits-svc-fork
2 participants
@sbersier @34j