Fix logout segfault (#16)

voiceip · Oct 30, 2020 · 6616d3c · 6616d3c
1 parent 83b6b1a
commit 6616d3c
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/tinyphone/phone.cpp b/tinyphone/phone.cpp
@@ -89,15 +89,17 @@ namespace tp {
 	}
 
 	void TinyPhone::Logout(SIPAccount* acc) throw(pj::Error) {
-		try {
-			acc->UnRegister();
-		}
-		catch (Error& err) {
-			PJ_LOG(1, (__FILENAME__, "Logout Account UnRegister Error %s", err.reason.c_str()));
+		synchronized(add_acc_mutex) {
+			try {
+				acc->UnRegister();
+			}
+			catch (Error& err) {
+				PJ_LOG(1, (__FILENAME__, "Logout Account UnRegister Error %s", err.reason.c_str()));
+			}
+			accounts.erase(acc->Name());
+			delete (acc);
+			SaveAccounts();
 		}
-		delete (acc);
-		accounts.erase(acc->Name());
-		SaveAccounts();
 	}
 
 	int TinyPhone::Logout() throw(pj::Error) {