Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update epic claim confirmation text #128

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

luke-rie
Copy link
Contributor

should fix: #125

@WiLuX-Source
Copy link

This can fix the issue for a while but iframe is no longer opened. Iframe checks are broken and that also needs to be fixed.

@vogler
Copy link
Owner

vogler commented Apr 20, 2023

Can someone confirm that this change fixes it?
I think there are several strings - I've seen Thanks for your order before in the DOM while the script was checking for Thank you for buying and it was fine.

@vogler
Copy link
Owner

vogler commented Apr 20, 2023

This can fix the issue for a while but iframe is no longer opened. Iframe checks are broken and that also needs to be fixed.

What do you mean? The text is checked on page, not iframe. I don't see a change - the order still happens in iframe.

@WiLuX-Source
Copy link

This can fix the issue for a while but iframe is no longer opened. Iframe checks are broken and that also needs to be fixed.

What do you mean? The text is checked on page, not iframe. I don't see a change - the order still happens in iframe.

My bad. Yes it creates iframe again but after seeing changed reactmodal i mistaken it for the window. All fine.

I confirm that this pr fixes the current issue with validating if the game is picked or not.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Epic - Failed to claim log message but game was claimed
3 participants