Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Rename Annotation.audio_path -> Annotation.notated_path #169

Merged
merged 3 commits into from
May 14, 2022

Conversation

NickleDave
Copy link
Collaborator

Fixes #148

- Rename attribute
- Use 'Annotation.notated_path' in all formats;
  keep `audio_path` attribute for formats
  but convert to `notated_path` inside `to_annot` method
- Regenerate files in tests/data_for_tests/csv/
- Fix column name in example_user_annotation.csv
  manually; will remove this along with
  user annotation format in a separate PR I think
@NickleDave NickleDave merged commit d80715b into main May 14, 2022
@NickleDave NickleDave deleted the rename-annot-notated-path branch May 15, 2022 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename Annotation.audio_path attribute to notated_path
1 participant