Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make extension checking for phn2annot case-insensitive #68

Closed
NickleDave opened this issue Jan 6, 2021 · 2 comments
Closed

make extension checking for phn2annot case-insensitive #68

NickleDave opened this issue Jan 6, 2021 · 2 comments

Comments

@NickleDave
Copy link
Collaborator

phn2annot throws an error because it looks for files with extension .wav, not .WAV
@NickleDave NickleDave changed the title make extension checking case-insensitive make extension checking for phn2annot case-insensitive Jan 6, 2021
@NickleDave
Copy link
Collaborator Author

don't need to worry about other built-in formats:
koumura files all end in .wav
and textgrid doesn't actually open the .wav file to get the sampling rate / frequency,
and the user can specify another extension (e.g., '.WAV') if they need to

@NickleDave
Copy link
Collaborator Author

need to also make phn2annot case-insensitive WRT the .phn files because some versions of TIMIT use .PHN (capitalized) as the extension

this will be trickier because of the _parse_files function. Make it accept a list of extensions?

NickleDave added a commit that referenced this issue Jan 7, 2021
@NickleDave
make phn2annot case-insensitive for phn files, fix #68
c1708d5 
by using the modified `_parse_file` function
that can accept multiple extensions as valid

`phn2annot` will now check for both `.phn` and `.PHN` extensions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NickleDave