Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: use impl instead of type generic #300

Merged
merged 1 commit into from
Jun 15, 2024
Merged

misc: use impl instead of type generic #300

merged 1 commit into from
Jun 15, 2024

Conversation

vnghia
Copy link
Owner

@vnghia vnghia commented Jun 15, 2024

No description provided.

Copy link

codecov bot commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 95.06173% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.55%. Comparing base (e2d8b01) to head (e80948a).
Report is 1 commits behind head on main.

Files Patch % Lines
src/open_subsonic/common/params.rs 77.77% 0 Missing and 2 partials ⚠️
src/open_subsonic/media_retrieval/get_cover_art.rs 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
- Coverage   80.58%   80.55%   -0.04%     
==========================================
  Files         213      213              
  Lines       12230    12224       -6     
  Branches    12230    12224       -6     
==========================================
- Hits         9856     9847       -9     
- Misses       1732     1734       +2     
- Partials      642      643       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vnghia vnghia merged commit 718daf7 into main Jun 15, 2024
16 checks passed
@vnghia vnghia deleted the as-ref-path branch June 15, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant