Array operators #23
Closed
Array operators #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BastiaanOlij
force-pushed
the
array_operator
branch
from
e2ec9f4 to
470aca3
Compare
BastiaanOlij
commented
Sep 18, 2021
| @@ -71,6 +71,14 @@ void Example::_bind_methods() { | |||
| BIND_CONSTANT(CONSTANT_WITHOUT_ENUM); | |||
| } | |||
|
|
|||
| Example::Example() { | |||
| UtilityFunctions::print("Constructor."); | |||
There was a problem hiding this comment.
Unrelated, added these for testing, but worth keeping in here I think.
|
@vnen can you review and merge? looks like its working :) |
BastiaanOlij
force-pushed
the
array_operator
branch
2 times, most recently
from
2e7b766 to
86dd468
Compare
BastiaanOlij
commented
Sep 20, 2021
| Array arr; | ||
|
|
||
| arr.resize(2); | ||
| arr[0] = Variant(1); |
There was a problem hiding this comment.
@vnen so this test case currently crashes but seemingly not in relation to the array but the way the variants are accessed.
Any chance you could try out my PR and see the crash for yourself? I haven't got a clue what is going on here.
|
I did look into this but I couldn't yet figure out why this is crashing. It definitely has a bogus Variant value, probably not properly constructed, but I can't tell where exactly it is. |
BastiaanOlij
force-pushed
the
gdnative-extensions
branch
3 times, most recently
from
5b49003 to
d5e0fc8
Compare
BastiaanOlij
force-pushed
the
array_operator
branch
from
86dd468 to
075c932
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add array operators to GD extensions
relies on godotengine/godot#52739