pkg/vsphere/tags: Add UpdateCategory

[vancluever]

Just adding the update (PATCH) method for a category. Pretty basic,
sourced from the create method, with new types added to specifically
denote update parameters.

[vmwclabot]

@vancluever, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

[hmahmood]

Would this work?

type CategoryUpdate CategoryCreate

[vancluever]

Hey @hmahmood - I think you all might know better that me in this respect, but even though the fields are the same, personally I would leave it properly typed and keep the name and the redundancy. They are, technically, separate types all the way down (see update_spec doc here), so I think the client should reflect that.

Personally I think things should have been structured like the following, which kind of illustrates my point a bit better:

type CategoryCreateInput struct {
	CreateSpec CategoryCreateSpec `json:"create_spec"`
}

type CategoryUpdateInput struct {
	UpdateSpec CategoryUpdateSpec `json:"update_spec"`
}

type CategoryCreateSpec struct {
	AssociableTypes []string `json:"associable_types"`
	Cardinality     string   `json:"cardinality"`
	Description     string   `json:"description"`
	Name            string   `json:"name"`
}

type CategoryUpdateSpec struct {
	AssociableTypes []string `json:"associable_types"`
	Cardinality     string   `json:"cardinality"`
	Description     string   `json:"description"`
	Name            string   `json:"name"`
}

[vmwclabot]

@vancluever, your company's legal contact has approved your signed contributor license agreement. It will also be reviewed by VMware, but the merge can proceed.

[vmwclabot]

@vancluever, VMware has approved your signed contributor license agreement.

[dougm]

lgtm

btw, we have moved packages from pkg/vsphere in the past to govmomi. Open to that and/or a separate repo for the rest based vAPIs.