[vdk-heartbeat] Fix successful run status check #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently functionality for checking if the data job finished successfully was added. It checks if the last execution of the data job was successful - status 'succeeded'. Check if status is 'succeeded', not 'success'. Testing Done: ran vdk-heartbeat locally with successful_run_test, and it finished successfully. Signed-off-by: Yana Zhivkova <yzhivkova@vmware.com>
gabrielgeorgiev1
approved these changes
Feb 21, 2022
YanaZhivkova
deleted the
person/yzhivkova/Fix_vdk-heartbeat_successful_run_check
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently functionality for checking if the data job finished
successfully was added. It checks if the last execution of
the data job was successful - status 'succeeded'.
Check if status is 'succeeded', not 'success'.
Testing Done: ran vdk-heartbeat locally with
successful_run_test, and it finished successfully.
Signed-off-by: Yana Zhivkova yzhivkova@vmware.com