vdk-control-cli: Parse contacts with both comma "," as delimiter as well #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielgeorgiev1
suggested changes
Feb 21, 2022
projects/vdk-control-cli/src/vdk/internal/control/job/job_config.py
Outdated
Show resolved
Hide resolved
Until now we required contacts be separated by ";" semi-colon. This was error prone as a lot of users are using "," comma and we are not really preventing them so mails were written as "a@abv.bg,b@dir.bg" as if it is a single email. T This also meant that people were not getting notifications. The fix is to add "," comma as allowed delimiter as a first step. In a subsequent change we can add a email validator (like https://pypi.org/project/email-validator) Testing Done: unit tests including new ones Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
antoniivanov
force-pushed
the
person/aivanov/vdk-control-cli-fix-parsing-contacts
branch
from
85a28f9 to
472dc21
Compare
gabrielgeorgiev1
approved these changes
Feb 21, 2022
antoniivanov
deleted the
person/aivanov/vdk-control-cli-fix-parsing-contacts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now we required contacts be separated by ";" semi-colon. This was
error prone as a lot of users are using "," comma and we are not really
preventing them so mails were written as "a@abv.bg,b@dir.bg" as if it is
a single email. T This also meant that people were not getting
notifications.
The fix is to add "," comma as allowed delimiter as a first step.
In a subsequent change we can add a email validator (like
https://pypi.org/project/email-validator)
Testing Done: unit tests including new ones
Signed-off-by: Antoni Ivanov aivanov@vmware.com