Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control-service: graphQL job executions filter by teamName #702

Merged
merged 6 commits into from
Feb 17, 2022

Conversation

mrMoZ1
Copy link
Contributor

@mrMoZ1 mrMoZ1 commented Feb 14, 2022

why: Users requested additional API functionality which includes
filtering and sorting data job executions by data job team name.
This will help operators monitor overall executions status.

what: Added new fields to graphql schema and extended
existing control-service functionality to cover requested fields.

testing: Added unit tests which cover the new functionality.

Signed-off-by: Momchil Zhivkov mzhivkov@vmware.com

Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
@mivanov1988
Copy link
Collaborator

Could you please provide the SQL query that has been generated by Hibernate?

Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
@mrMoZ1
Copy link
Contributor Author

mrMoZ1 commented Feb 15, 2022

Could you please provide the SQL query that has been generated by Hibernate?

SELECT datajobexe0_.id                       AS id1_1_,
       datajobexe0_.job_name                 AS job_nam18_1_,
       datajobexe0_.end_time                 AS end_time2_1_,
       datajobexe0_.job_schedule             AS job_sche3_1_,
       datajobexe0_.job_version              AS job_vers4_1_,
       datajobexe0_.last_deployed_by         AS last_dep5_1_,
       datajobexe0_.last_deployed_date       AS last_dep6_1_,
       datajobexe0_.message                  AS message7_1_,
       datajobexe0_.op_id                    AS op_id8_1_,
       datajobexe0_.resources_cpu_limit      AS resource9_1_,
       datajobexe0_.resources_cpu_request    AS resourc10_1_,
       datajobexe0_.resources_memory_limit   AS resourc11_1_,
       datajobexe0_.resources_memory_request AS resourc12_1_,
       datajobexe0_.start_time               AS start_t13_1_,
       datajobexe0_.started_by               AS started14_1_,
       datajobexe0_.status                   AS status15_1_,
       datajobexe0_.type                     AS type16_1_,
       datajobexe0_.vdk_version              AS vdk_ver17_1_
FROM   data_job_execution datajobexe0_
       CROSS JOIN data_job datajob1_
WHERE  datajobexe0_.job_name = datajob1_.NAME
       AND ( datajob1_.team IN ( ? ) ) 

@mivanov1988
Copy link
Collaborator

Please add IT test.

mrMoZ1 added 2 commits February 15, 2022 19:54
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
@mrMoZ1 mrMoZ1 enabled auto-merge (squash) February 16, 2022 08:40
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
@mrMoZ1 mrMoZ1 merged commit bedaf2a into main Feb 17, 2022
@mrMoZ1 mrMoZ1 deleted the person/mzhivkov/graphql-filter-executions-team branch February 17, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants