vdk-impala: impala templates #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
mrMoZ1
changed the title
|
Let's try to follow https://github.com/vmware/versatile-data-kit/wiki/How-to-prepare-a-new-PR#break-your-code-commits-into--small-self-contained-units Split each template into separate PR is a good way to do that in this concrete case |
ivakoleva
reviewed
Jan 17, 2022
projects/vdk-plugins/vdk-impala/src/vdk/plugin/impala/impala_helper.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-impala/src/vdk/plugin/impala/impala_helper.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-impala/src/vdk/plugin/impala/templates/template.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-impala/src/vdk/plugin/impala/templates/template.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-impala/src/vdk/plugin/impala/templates/template_executor.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-impala/src/vdk/plugin/impala/templates/template_executor.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-impala/tests/template_regression_test.py
Outdated
Show resolved
Hide resolved
|
haven't yet looked at the content of jobs/ in tests/ dir; |
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
ivakoleva
reviewed
Jan 20, 2022
projects/vdk-plugins/vdk-impala/tests/jobs/load_versioned_template_partition_job/__init__.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-impala/tests/template_regression_test.py
Outdated
Show resolved
Hide resolved
ivakoleva
requested changes
Jan 20, 2022
projects/vdk-plugins/vdk-impala/tests/template_regression_test.py
Outdated
Show resolved
Hide resolved
added 3 commits
January 20, 2022 17:50
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
ivakoleva
added a commit
that referenced
this pull request
Jan 21, 2022
There were issues with syntax support of the previous Impala docker image used for tests. Did search and found a viable solution that runs a newer Impala version. Testing Done: did run vdk-impala tests locally to verify, all tests pass, including the ones on Impala templates support draft MR #671 Signed-off-by: ikoleva <ikoleva@vmware.com>
ivakoleva
added a commit
that referenced
this pull request
Jan 24, 2022
There were issues with syntax support of the previous Impala docker image used for tests. Did search and found a viable solution that runs a newer Impala version. Testing Done: did run vdk-impala tests locally to verify, all tests pass, including the ones on Impala templates support draft MR #671 Signed-off-by: ikoleva <ikoleva@vmware.com>
|
Is it ready for review? |
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
mrMoZ1
changed the title
ivakoleva
approved these changes
Jan 26, 2022
added 3 commits
January 26, 2022 12:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what: Added impala templates for:
Slowly Changing Dimension Type 1
Slowly Changing Dimension Type 2 (subtypes)
Snapshot Accumulating Fact Table
why: Users requested templates similar to the ones in the
vdk-trino plugin. This is the implementation.
testing: added functional tests(data jobs that check if
templates are executing properly)
Signed-off-by: mrMoZ1 mzhivkov@vmware.com