vdk-oracle: support thick mode by default #2970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mivanov1988
approved these changes
Dec 12, 2023
DeltaMichael
force-pushed
the
person/mdilyan/oracle-thick
branch
from
424b48c to
ee0ce08
Compare
gabrielgeorgiev1
approved these changes
Dec 13, 2023
projects/vdk-plugins/vdk-oracle/src/vdk/plugin/oracle/oracle_configuration.py
Outdated
Show resolved
Hide resolved
Why? Internal deployments use thick mode and have the oracle driver bundled in their docker image. What? Add a config option for thick mode and set the default to True How was this tested? CI What kind of change is this? Feature/non-breaking Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
DeltaMichael
force-pushed
the
person/mdilyan/oracle-thick
branch
from
ee0ce08 to
73c627a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Internal deployments use thick mode and have the oracle driver bundled in their docker image.
What?
Add a config option for thick mode and set the default to True
How was this tested?
Ran code connection against a version 10c database, which requires thick mode
CI
What kind of change is this?
Feature/non-breaking