vdk-structlog: filter vdk_step_name and vdk_step_type correctly #2968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duyguHsnHsn
approved these changes
Dec 12, 2023
Why? vdk_step_name and vdk_step_type were not filtered correctly when using json format What? Make sure the metadata filter alwats executes last, even when vdk_step_name and vdk_step_type are involved Add separate functional test for vdk_step_name and vdk_step_type to avoid conflict with file_name in other tests How was this tested? Functional tests What kind of change is this? Feature/non-breaking Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
DeltaMichael
force-pushed
the
person/mdilyan/filter-step-name-type
branch
from
2001da5 to
dfa0ed2
Compare
for more information, see https://pre-commit.ci
gabrielgeorgiev1
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
vdk_step_name and vdk_step_type were not filtered correctly when using json format
What?
Make sure the metadata filter alwats executes last, even when vdk_step_name and vdk_step_type are involved
Add separate functional test for vdk_step_name and vdk_step_type to avoid conflict with file_name in other tests
How was this tested?
Functional tests
What kind of change is this?
Feature/non-breaking