control-service: fix read deployment job version #2819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakodakov
approved these changes
Oct 20, 2023
murphp15
approved these changes
Oct 23, 2023
Why The Read Deployment API returns incorrect data. What Changed the job version to point to git commit sha instead of deployment version. Signed-off-by: Miroslav Ivanov miroslavi@vmware.com
mivanov1988
force-pushed
the
person/miroslavi/fix-deployment-read-job-version
branch
from
f9aa7d4 to
c362471
Compare
mivanov1988
deleted the
person/miroslavi/fix-deployment-read-job-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The Read Deployment API returns incorrect data.
What
Changed the job version to point to git commit sha instead of deployment version.
Signed-off-by: Miroslav Ivanov miroslavi@vmware.com