control-service: handle deployment deletion in case of a job being deleted #2816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mivanov1988
changed the title
mivanov1988
force-pushed
the
person/miroslavi/improve-async-deployment-deletion
branch
from
6757a79 to
2ce3965
Compare
antoniivanov
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Looks good to me. Thanks for addressing those changes.
Please make sure vdk-heartbeat passes reliably (3 times in sequence for example).
I am concerned that changing from syncrhouos to more async/eventual consistence model might introduce some intermittent issues so do not rely on passing immediately and monitor the control service pipeline a few days after the merge.
...nes_control_service/src/main/java/com/vmware/taurus/service/deploy/DataJobsSynchronizer.java
Show resolved
Hide resolved
...ce/src/integration-test/java/com/vmware/taurus/service/deploy/DataJobDeploymentCrudITV2.java
Show resolved
Hide resolved
mivanov1988
force-pushed
the
person/miroslavi/improve-async-deployment-deletion
branch
from
0a7181f to
2ce3965
Compare
I've introduced the initial version of async job deployment integration tests. This is just the starting point, and we plan to expand and refactor it further in the upcoming version based on feedback from aivanov's comment. You can find the discussion on this change in the following link: Link to the GitHub pull request discussion Signed-off-by: Miroslav Ivanov miroslavi@vmware.com
mivanov1988
force-pushed
the
person/miroslavi/improve-async-deployment-deletion
branch
from
a758c55 to
9c8baa8
Compare
…leted Why When the data job is deleted, both desired deployment records are deleted, but the actual deployment records and Kubernetes cron jobs are still present. What Extended the deployment synchronization to cover this scenario. Testing done Integration tests. Signed-off-by: Miroslav Ivanov miroslavi@vmware.com
mivanov1988
force-pushed
the
person/miroslavi/improve-async-deployment-deletion
branch
from
5109362 to
5d54cb5
Compare
mivanov1988
deleted the
person/miroslavi/improve-async-deployment-deletion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When the data job is deleted, both desired deployment records are deleted, but the actual deployment records and Kubernetes cron jobs are still present.
What
Extended the deployment synchronization to cover this scenario. Added an additional flyway script as part of the integration tests because of the different H2 constraint naming.
Testing done
Integration tests.
Signed-off-by: Miroslav Ivanov miroslavi@vmware.com