control-service: add IT tests for async job deployment #2794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mivanov1988
force-pushed
the
person/miroslavi/add-it-tests-for-async-deployment
branch
from
a5f3aa4 to
5cef53a
Compare
mivanov1988
changed the title
|
typo in the title, should be add in* |
I think "it" in this case means IT (Integration Test). |
murphp15
reviewed
Oct 16, 2023
projects/control-service/projects/helm_charts/pipelines-control-service/values.yaml
Show resolved
Hide resolved
murphp15
requested changes
Oct 16, 2023
mivanov1988
changed the title
mivanov1988
changed the title
...ce/src/integration-test/java/com/vmware/taurus/datajobs/it/DataJobDeploymentCrudAsyncIT.java
Outdated
Show resolved
Hide resolved
mivanov1988
force-pushed
the
person/miroslavi/add-it-tests-for-async-deployment
branch
3 times, most recently
from
acdcf96 to
c40da8e
Compare
dakodakov
reviewed
Oct 18, 2023
...lines_control_service/src/main/java/com/vmware/taurus/service/deploy/JobImageDeployerV2.java
Outdated
Show resolved
Hide resolved
I've introduced the initial version of async job deployment integration tests. This is just the starting point, and we plan to expand and refactor it further in the upcoming version based on feedback from aivanov's comment. You can find the discussion on this change in the following link: Link to the GitHub pull request discussion Signed-off-by: Miroslav Ivanov miroslavi@vmware.com
mivanov1988
force-pushed
the
person/miroslavi/add-it-tests-for-async-deployment
branch
from
65c72e2 to
a1427ee
Compare
antoniivanov
approved these changes
Oct 19, 2023
murphp15
approved these changes
Oct 19, 2023
mivanov1988
deleted the
person/miroslavi/add-it-tests-for-async-deployment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've introduced the initial version of async job deployment integration tests. This is just the starting point, and we plan to expand and refactor it further in the upcoming version based on feedback from @antoniivanov 's comment. You can find the discussion on this change in the following link: Link to the GitHub pull request discussion.
Signed-off-by: Miroslav Ivanov miroslavi@vmware.com