control-service: job resources validation on job deployment #2793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: Unlike the old deployment approach, the new one propagates job resources to the job deployment process. What: Added validation of job resources during job deployment. If any job resources, such as CPU or memory, are provided, the job deployment will fail. Testing done: Integration tests Signed-off-by: Miroslav Ivanov miroslavi@vmware.com
mivanov1988
force-pushed
the
person/miroslavi/validate-recources-on-job-deployment
branch
from
1d3b77b to
a485769
Compare
dakodakov
approved these changes
Oct 12, 2023
antoniivanov
approved these changes
Oct 12, 2023
mivanov1988
deleted the
person/miroslavi/validate-recources-on-job-deployment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Unlike the old deployment approach, the new one propagates job resources to the job deployment process.
What:
Added validation of job resources during job deployment. If any job resources, such as CPU or memory, are provided, the job deployment will fail.
Testing done:
Integration tests.
Signed-off-by: Miroslav Ivanov miroslavi@vmware.com