vdk-core: simplify error message for send_**_for_ingestion #2787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
projects/vdk-core/src/vdk/internal/builtin_plugins/ingestion/ingester_router.py
Show resolved
Hide resolved
DeltaMichael
approved these changes
Oct 11, 2023
mivanov1988
approved these changes
Oct 11, 2023
There were a couple of issues with error handling that are fixedhere 1. Inconsistent behaviour between send_xxx methods. One method was swallowing the error while the other was re-throwing it . This is fixe by both rethrowing it. 2. Remove the unecessary error message. It is redundant and doesn't provide any new information that is not availbe in the raised exception 3. When "rows" argument was not iterabot nor cursor or iterable raised custom exceptin, it always failed with cryptic error ` AttributeError: 'BrokenIterator' object has no attribute 'fetchmany' ` This is fixed by using more appropriate if statement to cehck type of rows and raising InvalidArgumentsIngestionException if it's the wrong type. Consolited some tests in function/ingestion module. There was no test covering the scenario of using multiple methods and it is added.
antoniivanov
force-pushed
the
person/aivanov/vdk-core-errors
branch
from
6132bef to
784f29b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of issues with error handling that are fixedhere
Inconsistent behaviour between send_xxx methods. One method was swallowing the error while the other was re-throwing it . This is fixe by both rethrowing it.
Remove the unecessary error message. It is redundant and doesn't provide any new information that is not availbe in the raised exception
When "rows" argument was not iterabot nor cursor or iterable raised custom exceptin, it always failed with cryptic error
AttributeError: 'BrokenIterator' object has no attribute 'fetchmany'This is fixed by using more appropriate if statement to cehck type of rows and raising InvalidArgumentsIngestionException if it's the wrong type.Consolited some tests in function/ingestion module. There was no test covering the scenario of using multiple methods and it is added.
Testing Done: beyond automated test see