vdk-impala: introduce new error handling #2759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaMichael
reviewed
Oct 5, 2023
projects/vdk-plugins/vdk-impala/src/vdk/plugin/impala/templates/template_arguments_validator.py
Show resolved
Hide resolved
DeltaMichael
approved these changes
Oct 5, 2023
duyguHsnHsn
changed the title
gabrielgeorgiev1
approved these changes
Oct 5, 2023
antoniivanov
previously requested changes
Oct 5, 2023
dakodakov
approved these changes
Oct 5, 2023
|
LGTM |
duyguHsnHsn
deleted the
person/hduygu/vdk-impala-introduce-new-error-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #2680
I have Removed the log_and_throw and log_and_rethrow patterns from vdk-impala.
Also renamed ResolvableBy to ErrorType and ResolvableByActual to ResolvableBy in most places (it is not removed in some places because it requires vdk-core modifications, those changes will be introduced in later PRs)