vdk-core: create ingestion exceptions #2752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
commented
Oct 3, 2023
projects/vdk-core/src/vdk/internal/builtin_plugins/ingestion/exception.py
Outdated
Show resolved
Hide resolved
antoniivanov
commented
Oct 3, 2023
projects/vdk-core/src/vdk/internal/builtin_plugins/ingestion/exception.py
Outdated
Show resolved
Hide resolved
DeltaMichael
reviewed
Oct 3, 2023
projects/vdk-core/src/vdk/internal/builtin_plugins/ingestion/exception.py
Show resolved
Hide resolved
DeltaMichael
reviewed
Oct 3, 2023
projects/vdk-core/src/vdk/internal/builtin_plugins/ingestion/ingester_router.py
Show resolved
Hide resolved
DeltaMichael
approved these changes
Oct 3, 2023
antoniivanov
force-pushed
the
person/aivanov/vdk-core-errors
branch
2 times, most recently
from
897bee4 to
a398195
Compare
gabrielgeorgiev1
approved these changes
Oct 4, 2023
antoniivanov
force-pushed
the
person/aivanov/vdk-core-errors
branch
from
a398195 to
5ea9c1a
Compare
Replacing generic exception names like DomainError, UserCodeError, , and PlatformServiceError with more domain-specific exceptions (in this case the domain being ingestion) can offer differnet benefits See #2682 VdkConfigurationError is not changed as it's pretty clear for now. I am wondering if it still might not be better ot have IngsetionConfigurationException but could not decide and omit it from this change.
antoniivanov
force-pushed
the
person/aivanov/vdk-core-errors
branch
from
5ea9c1a to
66fefef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing generic exception names like DomainError, UserCodeError, , and PlatformServiceError with more domain-specific exceptions (in this case the domain being ingestion) can offer differnet benefits
See #2682
VdkConfigurationError is not changed as it's pretty clear for now. I am wondering if it still might not be better ot have IngsetionConfigurationException but could not decide and omit it from this change.
TODO: I still need to test with "real" like job that fails in some of those ways and see what is the difference in logs and in how the exception can be handled