vdk-notebook: set summary file path as configuration #2709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duyguHsnHsn
approved these changes
Sep 28, 2023
projects/vdk-core/src/vdk/internal/builtin_plugins/run/summary_output.py
Show resolved
Hide resolved
DeltaMichael
approved these changes
Sep 28, 2023
antoniivanov
force-pushed
the
person/aivanov/notebook
branch
3 times, most recently
from
563b85d to
994b21f
Compare
Previously, the summary file path was hard-coded to the job directory, posing issues for certain deployments where writing to the job directory was restricted. This led to failures in some deployments. The second problem. This design introduced a hidden and unsafe dependency between the vdk-notebook and vdk-jupyter plugins. The vdk-notebook plugin was responsible for writing the summary information, while vdk-jupyter read from the same hard-coded location, although both plugins operated independently. This commit migrates the summary file path logic to a more appropriate location.The functionality to output summary of the job in a way that differnet consumers (plugins or tools) can read and understand is rather generic and core functionality regardless if vdk-notebook is installed or not. After merging this would change vdk-jupyter to work with this and remove the obsolete code in vdk-noteboook
antoniivanov
force-pushed
the
person/aivanov/notebook
branch
from
994b21f to
4021ac5
Compare
antoniivanov
added a commit
that referenced
this pull request
Sep 29, 2023
This is no longer used superseded by vdk-core change in #2709
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the summary file path was hard-coded to the job directory, posing issues for certain deployments where writing to the job directory was restricted. This led to failures in some deployments.
The second problem. This design introduced a hidden and unsafe dependency between the vdk-notebook and vdk-jupyter plugins. The vdk-notebook plugin was responsible for writing the summary information, while vdk-jupyter read from the same hard-coded location, although both plugins operated independently.
This commit migrates the summary file path logic to a more appropriate location.The functionality to output summary of the job in a way that differnet consumers (plugins or tools) can read and understand is rather generic and core functionality regardless if vdk-notebook is installed or not.
After merging this would change vdk-jupyter to work with this and remove the obsolete code in vdk-noteboook