vdk-plugins: fix build of multiple plugins #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
force-pushed
the
person/aivanov/vdk-plugins
branch
8 times, most recently
from
f1b8241 to
9903824
Compare
antoniivanov
force-pushed
the
person/aivanov/vdk-plugins
branch
from
9903824 to
0b5c7da
Compare
antoniivanov
changed the title
doks5
approved these changes
Jul 25, 2023
murphp15
reviewed
Jul 25, 2023
murphp15
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were overall 3 issues that needed to be fixed in the build of those plugins:
The first one is 2.0 major release of pytest-docker (https://pypi.org/project/pytest-docker/#history) which we use for starting docker container in some plugin tests . This impacted us because
docker-composetodocker compose(no dash)docker-composecommand (with a dash)--
The other problematic library is the installation of docker-compose itself :).
docker-compose depends on PyYaml and PyYAML is having the following issue: yaml/pyyaml#724 (in short a recent release of Cython 3.0 broke PyYAML)
As a workaround, we can pin
PyYAML==5.3.1And also remove eager (transitive) upgrades when installing the package with pip to reduce the chance of accidentally upgrading it.--
Finally removed all non- testing dependencies from requirements.txt. In one of the plugin was failing to install because it was missing install requirements in setup.py and was not caught during testing because requirements.txt was installing that dependency.
An alternative approach to fix it might have been to switch to use testcontainer (like vdk-trino uses) instead of pytest-docker + docker-compose. But that would require refactoring of the tests so I opted out for now.