vdk-core: Set sender when checking if email exists #2376
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a target email address is checked if exists, we set a dummy sender
"whatever"
. This works in cases, where the smtp server does not enforce validation checks on the sender. It does not, however, work in cases when the smtp server uses TLS (like Office365).In such cases, the check of the target email address fails with Status
503: Bad sequence of commands
, because the.mail("whatever")
method call sets the FROM field to mail FROM:, and this causes the smtp server to return501 5.1.7 Invalid address
.This change replces
"whatever"
with the actual sender address used to send the email notifications (set through theVDK_NOTIFICATION_SENDER
) environment variable.Testing Done:
Create a sample email script to first better understand the error, and second to verify that the fix actually works.
Script is: