control-service: a clear error message on how to handle the failed pipeline #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
murphp15
changed the title
duyguHsnHsn
approved these changes
May 25, 2023
|
Good improvement! |
mivanov1988
approved these changes
May 25, 2023
antoniivanov
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Often we get in a situation where the helm chart can't be deployed because the previous deployment is in a pending state.
There is not a clear way of how to handle this. However we need to tell ppl how to investigate it.
for the last week all deployments failed because there was a deployment in pending state for 1 week.
What
exit the deployment early if there is a deployment in pending-state and include in stdout help on how to debug it.
How was this tested
I pushed the system into an unstable state and the error message printed out:https://gitlab.com/vmware-analytics/versatile-data-kit/-/jobs/4348854403
I also tested when the system is in a stable state and it all looks good