vdk-server: logs url in quickstart vdk #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: murphp15 <murphp15@tcd.ie>
antoniivanov
reviewed
May 5, 2023
ivakoleva
approved these changes
May 9, 2023
DeltaMichael
approved these changes
May 10, 2023
Signed-off-by: murphp15 <murphp15@tcd.ie>
|
@ivakoleva @DeltaMichael |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In quickstart vdk we want to be able to see the logs of a job.
What
Read the logs from the api server
How was this tested
Ran it locally.
The logs endpoint in the api is not brilliant. It doesn't return anything unless the job is complete
images showing links in UI to links redirect link:
image showing logs for job not yet started:
image showing logs for completed job:
