Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-control-cli: Add support for python_version #2002

Merged
merged 4 commits into from
May 2, 2023

Conversation

doks5
Copy link
Contributor

@doks5 doks5 commented May 1, 2023

As part of the initiative to support multiple python versions for data job deployments, we need to make sure that users can configure their data jobs to use specific python versions, by setting the python_version property in the job's config.ini file.

This change introduces functionality in the vdk-control-cli client to read the python_version configuration set in the job's config.ini file, and deploy the job through vdk deploy ...

Testing Done: New and existing tests.

As part of the initiative to support multiple python versions for data job
deployments, we need to make sure that users can configure their data jobs to
use specific python versions, by setting the `python_version` property in the
job's **config.ini** file.

This change introduces functionality in the vdk-control-cli client to read the
python_version configuration set in the job's config.ini file, and deploy the
job through `vdk deploy ...`

Testing Done: New and existing tests.

Signed-off-by: Andon Andonov <andonova@vmware.com>
@doks5 doks5 self-assigned this May 1, 2023
@doks5 doks5 added this to the Multiple Python Versions Support milestone May 1, 2023
@doks5 doks5 linked an issue May 1, 2023 that may be closed by this pull request
@mivanov1988 mivanov1988 enabled auto-merge (squash) May 2, 2023 08:21
@mivanov1988 mivanov1988 merged commit 3988d1d into main May 2, 2023
@mivanov1988 mivanov1988 deleted the person/andonova/control-cli-python branch May 2, 2023 09:46
doks5 added a commit that referenced this pull request May 2, 2023
doks5 added a commit that referenced this pull request May 2, 2023
yonitoo pushed a commit that referenced this pull request May 3, 2023
As part of the initiative to support multiple python versions for data
job deployments, we need to make sure that users can configure their
data jobs to use specific python versions, by setting the
`python_version` property in the job's **config.ini** file.

This change introduces functionality in the vdk-control-cli client to
read the python_version configuration set in the job's config.ini file,
and deploy the job through `vdk deploy ...`

Testing Done: New and existing tests.

Signed-off-by: Andon Andonov <andonova@vmware.com>
Co-authored-by: Miroslav Ivanov <40535952+mivanov1988@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Multiple Python Versions in VDK
4 participants