[vdk-plugins] vdk-ingest-http: Adopt simplejson in place of json #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The json package from the standard library is vey versatile and provides a lot of functionalities for json encoding and decoding. It, however, has some limitations when handling special python types like decimal.Decimal, which causes TypeErrors to be raised when ingesting payloads that contain such special types. This change adopts the simplejson package in place of the json package from the standard library. simplejson handles conversion of special types like decimal.Decimal to proper json types without loss of precision, https://simplejson.readthedocs.io/en/latest/#basic-usage Testing done: Added unit test Signed-off-by: Andon Andonov <andonova@vmware.com>
doks5
force-pushed
the
person/andonova/json-error
branch
from
b62f5f5 to
a5d0b6d
Compare
gabrielgeorgiev1
approved these changes
Oct 10, 2022
dakodakov
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The json package from the standard library is vey versatile and provides a lot of functionalities for json encoding and decoding. It, however, has some limitations when handling special python types like decimal.Decimal, which causes TypeErrors to be raised when ingesting payloads that contain such special types.
This change adopts the simplejson package in place of the json package from the standard library. simplejson handles conversion of special types like decimal.Decimal to proper json types without loss of precision, https://simplejson.readthedocs.io/en/latest/#basic-usage
Testing done: Added unit test
Signed-off-by: Andon Andonov andonova@vmware.com