Compare checksum for repodata against the downloaded rpm file #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shivania2, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
shivania2
force-pushed
the
topic/shivania/checksum
branch
from
ec51883
to
724aade
Compare
shivania2
force-pushed
the
topic/shivania/checksum
branch
from
724aade
to
7429e00
Compare
|
Thank you Shivani! This looks good. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tdnf when downloading packages (or using from a repo accessible as a file), does not check for the checksum which is provided in the metadata. Recently there is a issue caught https://bugzilla.eng.vmware.com/show_bug.cgi?id=3237405(Fixed by checking the size), a proper check would have caught this issue earlier.