Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcsim: add ssoadmin user and group management #3051

Merged
merged 1 commit into from
Mar 19, 2023

Conversation

dougm
Copy link
Member

@dougm dougm commented Feb 20, 2023

Description

The ssoadmin endpoint is now used for authentication for both SOAP and REST endpoints. Previous behavior is retained:

  • By default, any non-empty username + password is authenticated
  • If vcsim '-username' and '-password' flags are given, only those credentials can be used for authentication

Additional users can be added via the ssoadmin APIs or using govc for example:

  % govc sso.user.create -p password govc

Closes: #2852

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

Added bats tests

Checklist:

  • My code follows the CONTRIBUTION
    guidelines of
    this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

@dougm dougm requested a review from hickeng February 20, 2023 17:28
@dougm dougm force-pushed the vcsim-ssoadmin-users branch from 1c30fee to 0133d73 Compare February 20, 2023 17:52
@dougm dougm requested a review from dbhat-arkin March 17, 2023 17:16
@dougm dougm force-pushed the vcsim-ssoadmin-users branch from 0133d73 to 5f8639f Compare March 18, 2023 18:42
The ssoadmin endpoint is now used for authentication for both SOAP and REST endpoints.
Previous behavior is retained:
- By default, any non-empty username + password is authenticated
- If vcsim '-username' and '-password' flags are given, only those credentials can be used for authentication

Additional users can be added via the ssoadmin APIs or using govc for example:

  % govc sso.user.create -p password govc

Closes vmware#2852
@dougm dougm force-pushed the vcsim-ssoadmin-users branch from 5f8639f to c62983f Compare March 18, 2023 18:44
@dbhat-arkin
Copy link
Contributor

Changes looks good to me

Copy link
Contributor

@dbhat-arkin dbhat-arkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me.

@dougm dougm merged commit 6687830 into vmware:main Mar 19, 2023
@dougm dougm deleted the vcsim-ssoadmin-users branch March 19, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Requesting SSO user/group modification feature (on par with govc's)
3 participants