govc: add support for supervisor services deploy #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikatz
force-pushed
the
namespace-supervisor-svc-cmd
branch
6 times, most recently
from
da1a93a to
22e28d3
Compare
embano1
reviewed
Nov 24, 2021
embano1
reviewed
Nov 24, 2021
rikatz
force-pushed
the
namespace-supervisor-svc-cmd
branch
from
13df470 to
ef5c5c5
Compare
|
@dougm thanks for the review :) and sorry for the delay, a lot of other stuff ongoing here :/ Hopefully this is right now and all the tests will pass as well :) |
rikatz
force-pushed
the
namespace-supervisor-svc-cmd
branch
from
13d5593 to
331b699
Compare
|
Thx @rikatz ! Once the review is done, can you please squash your commits and follow our contribution guidelines in terms of title and message body (reference issue) so your work renders nicely in the CHANGELOG? |
Closes: 2690 Signed-off-by: Ricardo Katz <rkatz@vmware.com>
rikatz
force-pushed
the
namespace-supervisor-svc-cmd
branch
from
331b699 to
742f289
Compare
rikatz
changed the title
|
@embano1 happy holidays :) sorry for the delay, last days were busy! I have squashed the commits and rewritten the commit message to be aligned with contribution guideline. Thanks! |
|
Thx, LGTM but will ask @dougm to approve. |
dougm
approved these changes
Jan 4, 2022
dougm
added a commit
to dougm/govmomi
that referenced
this pull request
Jan 28, 2022
In PR vmware#2668 we refactored the 'StatusOK' method into a 'Status' method, which we don't need without a response body, as w.WriteHeader can be used directly instead.
dougm
added a commit
to dougm/govmomi
that referenced
this pull request
Feb 3, 2022
In PR vmware#2668 we refactored the 'StatusOK' method into a 'Status' method, which we don't need without a response body, as w.WriteHeader can be used directly instead.
dougm
added a commit
to dougm/govmomi
that referenced
this pull request
Feb 3, 2022
In PR vmware#2668 we refactored the 'StatusOK' method into a 'Status' method, which we don't need without a response body, as w.WriteHeader can be used directly instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ricardo Katz rkatz@vmware.com
Description
Initial work on supporting vSphere Namespaces supervisor services.
Right now it's possible to:
TODO: Write VCSIM things
Type of change
Please mark options that are relevant:
not work as expected)
How Has This Been Tested?
Tested with a real cluster. Still will check to write some unit tests
Checklist:
this project