-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: add toolbox Client.Run #2464
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, really useful!
Currently we don't highlight |
Move some initialization from govc to a toolbox.NewClient method that can be reused.
Simplifies Go tests that depend on container backed simulated VMs.
@embano1 yes, thanks, it'd be great to highlight |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Add simulator.RunContainer method, simplifies Go tests that depend on container backed simulated VMs.
Move some initialization from govc to a
toolbox.NewClient
method that can be reused.Closes: #2458
Type of change
Please mark options that are relevant:
not work as expected)
How Has This Been Tested?
Checklist:
this project