Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: add toolbox Client.Run #2464

Merged
merged 3 commits into from
May 27, 2021
Merged

examples: add toolbox Client.Run #2464

merged 3 commits into from
May 27, 2021

Conversation

dougm
Copy link
Member

@dougm dougm commented May 25, 2021

Description

Add simulator.RunContainer method, simplifies Go tests that depend on container backed simulated VMs.
Move some initialization from govc to a toolbox.NewClient method that can be reused.

Closes: #2458

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Existing guest.bats tests
  • The new example is run as a test itself

Checklist:

  • My code follows the CONTRIBUTION guidelines of
    this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

embano1
embano1 previously approved these changes May 26, 2021
Copy link
Contributor

@embano1 embano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, really useful!

@embano1
Copy link
Contributor

embano1 commented May 26, 2021

Currently we don't highlight examples: in the CHANGELOG. Let me know if I should add a highlight section there.

dougm added 3 commits May 26, 2021 07:29
Move some initialization from govc to a toolbox.NewClient method that can be reused.
Simplifies Go tests that depend on container backed simulated VMs.
@dougm
Copy link
Member Author

dougm commented May 26, 2021

@embano1 yes, thanks, it'd be great to highlight examples: in the CHANGELOG

Copy link
Contributor

@embano1 embano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dougm dougm merged commit bf423a5 into vmware:master May 27, 2021
@dougm dougm deleted the guest-toolbox branch May 27, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How I can do run code in vm, without govc ?
3 participants