Add vsan and disk commands / helpers #672
Conversation
dougm
force-pushed
the
vsan
branch
5 times, most recently
from
cb64ad5 to
10e587a
Compare
govc/datastore/disk/create.go
Outdated
| return `Create VMDK on DS. | ||
|
|
||
| Examples: | ||
| govc datastore.disk.create -size 24G disks/disk1.vmdk` |
There was a problem hiding this comment.
Is disks the datastore or is this on datastore by default?
There was a problem hiding this comment.
Need to datastore.mkdir first if it doesn't already exist, I'll add that to the example.
| @@ -43,6 +43,7 @@ func (cmd *rm) Register(ctx context.Context, f *flag.FlagSet) { | |||
| cmd.DatastoreFlag, ctx = flags.NewDatastoreFlag(ctx) | |||
| cmd.DatastoreFlag.Register(ctx, f) | |||
|
|
|||
| f.BoolVar(&cmd.kind, "t", true, "Use file type to choose disk or file manager") | |||
There was a problem hiding this comment.
might find out further down, but not sure what will be non-functional if this is set to false.
There was a problem hiding this comment.
We're using it in the datastore_file_manager.sh to test the vsan.dom commands
| } | ||
|
|
||
| if mds.Summary.Type != "vsan" { | ||
| return flag.ErrHelp |
There was a problem hiding this comment.
Perhaps include the fact that the target is not a vSAN datastore.
object/datastore_file_manager.go
Outdated
| func (m *DatastoreFileManager) markDiskAsDeletable(ctx context.Context, path *DatastorePath) { | ||
| r, n, err := m.Datastore.Download(ctx, path.Path, &soap.DefaultDownload) | ||
| if err != nil { | ||
| return |
There was a problem hiding this comment.
not returning a cause here may make it hard to differentiate between errors:
- disk in use
- missing Host.Config.SystemManagement privilege
- connection error
- other
There was a problem hiding this comment.
We discussed in person, I'll add comment/log.
object/datastore_file_manager.go
Outdated
| defer r.Close() | ||
|
|
||
| if n > 2048 { | ||
| return // sanity check before reading; should be only a few hundred bytes |
There was a problem hiding this comment.
This is true for the moment but we are discussing using the ddb to store the layer metadata. Regardless, if we've somehow accidentally downloaded the data file instead of the descriptor this will be Gigabytes too late - we could download only the first 512 bytes and check for known keys (for example) - not really thought about edge cases with this suggestion however.
There was a problem hiding this comment.
Regarding ddb for metadata, hopefully we won't still be using this workaround by then :)
Regarding the download, we've only read the HTTP headers at this point, 'n' is the value of the Content-Length header. Nothing reads the HTTP body until we call s.Scan() below.
There was a problem hiding this comment.
Changed to use https://golang.org/pkg/io/#LimitedReader instead of just checking the Content-Length header.
* Add DatastoreFileManager API wrapper * Add HostVsanInternalSystem API wrappers * Add govc datastore.disk.create command * Add govc datastore.vsan.dom.ls and datastore.vsan.dom.rm commands * Use DatastoreFileManager in govc datastore.rm command
Add DatastoreFileManager API wrapper
Add HostVsanInternalSystem API wrappers
Add govc datastore.disk.create command
Add govc datastore.vsan.ls and datastore.vsan.rm commands
Use DatastoreFileManager in govc datastore.rm command