Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Provide descriptive help in CONTRIBUTING.md file, when someone adds new govc command package #2708

Closed
pradeep288 opened this issue Jan 18, 2022 · 1 comment · Fixed by #2709
Closed

[BUG] Provide descriptive help in CONTRIBUTING.md file, when someone adds new govc command package #2708

pradeep288 opened this issue Jan 18, 2022 · 1 comment · Fixed by #2709

Comments

@pradeep288
Copy link
Contributor

pradeep288 commented Jan 18, 2022 •
edited
Loading

Describe the bug
Currently, for a new contributor, adding new govc command, we find no help message regarding how to register the new govc command pakcage in CONTRIBUTING.md

To Reproduce
NA

Expected behavior
Mention the following on the CONTRIBUTING.md file.

When a new govc command package is added, please register the new govc pakcage by importing into govmomi/govc/main.go file

Affected version
master

Screenshots/Debug Output
NA

Additional context
NA
@github-actions
Copy link
Contributor

Howdy 🖐   pradeep288 ! Thank you for your interest in this project. We value your feedback and will respond soon.

If you want to contribute to this project, please make yourself familiar with the CONTRIBUTION guidelines.

pradeep288 added a commit to pradeep288/govmomi that referenced this issue Jan 18, 2022
@pradeep288
govc: Update CONTIRBUTING.md file
a44a69b 
Closes: vmware#2708
@pradeep288 pradeep288 mentioned this issue Jan 18, 2022
Merged
11 tasks
pradeep288 added a commit to pradeep288/govmomi that referenced this issue Jan 19, 2022
@pradeep288 @embano1
Update CONTIRBUTING.md file
1d6c570 
Update CONTIRBUTING.md file

Closes: vmware#2708
Co-Authored-By: Michael Gasch <embano1@live.com>
pradeep288 added a commit to pradeep288/govmomi that referenced this issue Jan 21, 2022
@pradeep288
docs: Update CONTIRBUTING.md file
9317bda 
Closes: vmware#2708
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update CONTRIBUTING.md file pradeep288/govmomi
1 participant
@pradeep288