vcsim: avoid edit device panic when DeviceInfo is nil

vmware · May 7, 2021 · bd3467d · bd3467d
1 parent dfe03eb
commit bd3467d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/simulator/virtual_machine.go b/simulator/virtual_machine.go
@@ -1382,7 +1382,9 @@ func (vm *VirtualMachine) configureDevices(ctx *Context, spec *types.VirtualMach
 				return invalid
 			}
 			devices = vm.removeDevice(ctx, devices, &rspec)
-			device.DeviceInfo.GetDescription().Summary = "" // regenerate summary
+			if device.DeviceInfo != nil {
+				device.DeviceInfo.GetDescription().Summary = "" // regenerate summary
+			}
 
 			err := vm.configureDevice(ctx, devices, dspec)
 			if err != nil {

diff --git a/simulator/virtual_machine_test.go b/simulator/virtual_machine_test.go
@@ -374,6 +374,11 @@ func TestReconfigVmDevice(t *testing.T) {
 			t.Error(err)
 		}
 
+		d.GetVirtualDevice().DeviceInfo = nil
+		if err = vm.EditDevice(ctx, d); err != nil {
+			t.Error(err)
+		}
+
 		// RemoveDevice and delete the file backing
 		if err = vm.RemoveDevice(ctx, false, d); err != nil {
 			t.Error(err)