fix: support govc import.spec for remote ova

PR #1885 added support for remote ovf files, but not ova. Issue #1836
vmware · Feb 2, 2022 · ad66761 · ad66761
1 parent 4b34060
commit ad66761
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/govc/importx/spec.go b/govc/importx/spec.go
@@ -107,7 +107,7 @@ func (cmd *spec) Run(ctx context.Context, f *flag.FlagSet) error {
 			return fmt.Errorf("invalid file extension %s", path.Ext(fpath))
 		}
 
-		if isRemotePath(fpath) {
+		if isRemotePath(f.Arg(0)) {
 			client, err := cmd.Client()
 			if err != nil {
 				return err

diff --git a/govc/test/import.bats b/govc/test/import.bats
@@ -22,6 +22,9 @@ load test_helper
   run govc import.spec "https://$(govc env GOVC_URL)/folder/$TTYLINUX_NAME.ovf"
   assert_success
 
+  run govc import.spec "https://$(govc env GOVC_URL)/folder/$TTYLINUX_NAME.ova"
+  assert_success
+
   proto=$(jq -r .IPProtocol <<<"$output")
   assert_equal IPv4 "$proto"