Add "egressNodeName" field for Egress information support #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Atish-iaf, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
Atish-iaf
force-pushed
the
add-egressNode-field
branch
from
65da770 to
fc81671
Compare
|
Hi @antoninbas @heanlan |
antoninbas
reviewed
Feb 14, 2024
pkg/registry/registry_antrea.csv
Outdated
| @@ -56,3 +56,4 @@ ElementID,Name,Abstract Data Type,Data Type Semantics,Status,Description,Units,R | |||
| 154,egressIP,string,,current,,,,,,,,56506, | |||
| 155,appProtocolName,string,,current,,,,,,,,56506, | |||
| 156,httpVals,string,,current,,,,,,,,56506, | |||
| 157,egressNode,string,,current,,,,,,,,56506, | |||
There was a problem hiding this comment.
Given naming for other existing IEs (sourceNodeName and destinationNodeName), this should probably be called egressNodeName
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #343 +/- ##
==========================================
+ Coverage 72.73% 72.88% +0.14%
==========================================
Files 19 19
Lines 2853 2854 +1
==========================================
+ Hits 2075 2080 +5
+ Misses 604 602 -2
+ Partials 174 172 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Add a new field "egressNodeName" for the visibility of Egress information in flow records. Signed-off-by: Kumar Atish <katish@vmware.com>
Atish-iaf
force-pushed
the
add-egressNode-field
branch
from
fc81671 to
de98a58
Compare
Atish-iaf
changed the title
antoninbas
approved these changes
Feb 15, 2024
heanlan
pushed a commit
to heanlan/go-ipfix
that referenced
this pull request
Feb 15, 2024
Add a new field "egressNodeName" for the visibility of Egress information in flow records. Signed-off-by: Kumar Atish <katish@vmware.com>
|
Hi @Atish-iaf , go-ipfix v0.9.0 is released. Please feel free to use this tag in Antrea repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new field
egressNodeNamefor the visibility of Egress information in flow records.