Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logic to get a gcp project #926

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

shubheksha
Copy link
Contributor

Signed-off-by: Shubheksha Jalan jshubheksha@gmail.com
Fixes #329
/cc @skriss @ncdc

Signed-off-by: Shubheksha Jalan <jshubheksha@gmail.com>
@ncdc
Copy link
Contributor

ncdc commented Oct 11, 2018

LGTM, thanks @shubheksha!

Copy link
Contributor

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ncdc ncdc merged commit fe51be6 into vmware-tanzu:master Oct 11, 2018
@nrb nrb added this to the v0.9.8 milestone Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants