Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3159: Added support for AzureStackHub and Azure private cloud identification #8738

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

schaafito
Copy link

@schaafito schaafito commented Feb 28, 2025

Thank you for contributing to Velero!

Please add a summary of your change

Added support for AzureStackHub and private Azure cloud environments by updating the getCloudConfiguration() logic to fall-through to the kubernetes cloud-provider-azure module logic for identifying private cloud environments. This fall-through supports both AZURE_RESOURCE_MANAGER_ENDPOINT cloud discovery as well as AZURE_ENVIRONMENT_FILEPATH discovery.

The private cloud logic can (partially) be tested on any Azure environment by setting the AZURE_CLOUD_NAME to AZURESTACKCLOUD and providing a valid azurestackcloud.json configuration file as documented here. You can set the cloud endpoints to valid endpoints for a public cloud offering to test fallthrough logic.

The bulk of the documentation updates will need to be done on the velero-plugin-for-microsoft-azure project which I plan during the PR cycle to recompile the plugin with these changes. The proposed documentation changes can be seen on my branch

I provided unit tests for both endpoint and filepath cloud discovery, as well as tested in my own Azure environments to confirm functionality.

Note: This feature requires golang1.23 support so I bumped those as well. I see an open PR #8717 which I suspect will need to be merged before this.

Does your change fix a particular issue?

Fixes #3159

Please indicate you've done the following:

Signed-off-by: Ryan Schaaf <ryanschaaf@datamachines.com>
@github-actions github-actions bot requested review from sseago and ywk253100 February 28, 2025 11:13
@github-actions github-actions bot added Dependencies Pull requests that update a dependency file has-unit-tests labels Feb 28, 2025
@schaafito schaafito changed the title Issuer 3159: Added support for AzureStackHub and Azure private cloud identification Issue 3159: Added support for AzureStackHub and Azure private cloud identification Feb 28, 2025
Signed-off-by: Ryan Schaaf <ryanschaaf@datamachines.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file has-changelog has-unit-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable use with Azure Stack
1 participant