Ensure pkg/install do not import pkg/plugin/framework #8180
+55
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/kind changelog-not-required |
github-actions
bot
added
the
kind/changelog-not-required
kaovilai
force-pushed
the
unit-test-dependency-installpkg
branch
from
c0635ae
to
30a9224
Compare
kaovilai
force-pushed
the
unit-test-dependency-installpkg
branch
from
30a9224
to
55d1b0b
Compare
github-actions
bot
requested review from
anshulahuja98 and
shubham-pampattiwar
|
looks like 8145 ultimately failed to pass this test after some force pushes later. moving back to draft. |
kaovilai
changed the title
kaovilai
force-pushed
the
unit-test-dependency-installpkg
branch
from
4dd01bf
to
21b6dac
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8180 +/- ##
==========================================
- Coverage 59.21% 59.19% -0.03%
==========================================
Files 367 367
Lines 30708 30775 +67
==========================================
+ Hits 18184 18216 +32
- Misses 11069 11102 +33
- Partials 1455 1457 +2 ☔ View full report in Codecov by Sentry. |
kaovilai
force-pushed
the
unit-test-dependency-installpkg
branch
from
21b6dac
to
cb1ea3b
Compare
blackpiglet
previously approved these changes
Sep 11, 2024
|
This PR becomes unnecessary if #8208 merges. |
kaovilai
commented
Sep 11, 2024
3 tasks
kaovilai
changed the title
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com> Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
kaovilai
force-pushed
the
unit-test-dependency-installpkg
branch
from
95ac94d
to
27aa8e5
Compare
|
Closing this one as #8208 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tiger Kaovilai tkaovila@redhat.com
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #8157 (hopefully forever)
Rebased after #8145. This passes with #8145 and moving images.go away from /internal/velero which contain imports to pkg/plugin/framework which imports many cloud sdks. (created #8207)
This PR can be replaced or supplemented by #8208
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.