testifylint: enable go-require, float-compare and require-error rules

[mmorel-35]

Thank you for contributing to Velero!

Please add a summary of your change

Enable and fixes go-require and require-error rules of testifylint linter.

Also update golangci-lint version

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

• Accepted the DCO. Commits without the DCO will delay acceptance.
• Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
• Updated the corresponding documentation in site/content/docs/main.

[mmorel-35]

/kind changelog-not-required

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.06%. Comparing base (b5c9921) to head (da90147).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8027   +/-   ##
=======================================
  Coverage   59.06%   59.06%           
=======================================
  Files         364      364           
  Lines       30322    30322           
=======================================
  Hits        17909    17909           
  Misses      10970    10970           
  Partials     1443     1443           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mmorel-35]

@blackpiglet,
This condition seems odd, should it be this instead?

Suggested change

	if err != nil {
	if test.err != "" {

That's out of the scope of this PR but might worth a review. It's as if the assertions are done depending on the result and not there expected result.
And this happens in several places in this file.

[blackpiglet]

Thanks. I agree with you. Although both should work, the code should check the test.err instead.

[mmorel-35]

@Lyndon-Li ,
Would you like to review this when you find the time ?

[mmorel-35]

I have squashed and rebased all my commit now.

Please review this when you find the time.

[kaovilai]

I feel like require.EqualError should be sufficient here without if/else as long as you don't call .Error()
Comparing error type to error type should be fine IMO.

[mmorel-35]

I believe it’s out of scope of this PR. This only apply best practices while keeping actual tests working. Maybe you can do a PR following your suggestion in the same time ?

[kaovilai]

ok.