Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick][1.14]Check whether the volume's source is PVC before fetching its PV. #7976

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Jul 3, 2024

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #7929

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Signed-off-by: Xun Jiang <blackpigletbruce@gmail.com>
@blackpiglet blackpiglet changed the title Check whether the volume's source is PVC before fetching its PV. [cherry-pick][1.14]Check whether the volume's source is PVC before fetching its PV. Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.

Project coverage is 58.81%. Comparing base (77b3c8f) to head (dcf4e1f).

Files Patch % Lines
internal/volumehelper/volume_policy_helper.go 46.15% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.14    #7976      +/-   ##
================================================
+ Coverage         58.78%   58.81%   +0.02%     
================================================
  Files               346      346              
  Lines             28815    28818       +3     
================================================
+ Hits              16940    16949       +9     
+ Misses            10443    10438       -5     
+ Partials           1432     1431       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ywk253100 ywk253100 merged commit 163ee42 into vmware-tanzu:release-1.14 Jul 5, 2024
65 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants