Add additional keys from BSL secret to credentials file store #7943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
kaovilai
force-pushed
the
addAdditionalFilesFromSecretsToVeleroPod
branch
from
fc2b87d
to
8235f9b
Compare
kaovilai
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7943 +/- ##
=======================================
Coverage 58.79% 58.80%
=======================================
Files 345 345
Lines 28766 28770 +4
=======================================
+ Hits 16914 16918 +4
Misses 10423 10423
Partials 1429 1429 ☔ View full report in Codecov by Sentry. |
kaovilai
commented
Jun 27, 2024
| return "", errors.Wrap(err, "unable to close credentials file") | ||
| var credFilePath string | ||
| for key, data := range s.Data { | ||
| keyFilePath := filepath.Join(n.fsRoot, selector.Name, key) |
There was a problem hiding this comment.
This new key file path follows pattern suggested in #7767 comments.
Below was the original path pattern. Can use prior pattern for just the credentials secret key, or for all keys.
keyFilePath := filepath.Join(n.fsRoot, fmt.Sprintf("%s-%s", selector.Name, selector.Key))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tiger Kaovilai tkaovila@redhat.com
Thank you for contributing to Velero!
Please add a summary of your change
Add additional files from secret to velero pod without restart to assists with some BSL encryption file requirements without restarting pod. It may require readding BSL to trigger write.
Does your change fix a particular issue?
Fixes #7767
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.