Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to clarify the scope of issues. #7717

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

reasonerjt
Copy link
Contributor

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@reasonerjt reasonerjt added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Apr 22, 2024
@reasonerjt reasonerjt marked this pull request as draft April 22, 2024 10:55
Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com>
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.58%. Comparing base (5f9c53a) to head (b117963).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7717      +/-   ##
==========================================
- Coverage   58.60%   58.58%   -0.03%     
==========================================
  Files         343      343              
  Lines       28593    28593              
==========================================
- Hits        16757    16751       -6     
- Misses      10418    10423       +5     
- Partials     1418     1419       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

**NOTE**: The issues section in this repository is for tracking issues for upstream opensource velero. If you encounter
any issues while using a downstream product that consumes velero, like OADP, TMC Data Protection, please make sure to file a
ticket via the support channel of the product for the initial triage.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Maybe a bullet list below the note for specific downstream products with known support ticket URLs would be appropriate here, using the above for OADP, and accepting contribution for other links as appropriate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.. IMHO ideally we collect the right link/pointer to popular downstream support of Velero and link them together. In the hope users find the appropriate link and save upstream a bit of time and energy.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And another link for FAQ: https://red.ht/oadp-faq

@weshayutin
Copy link
Contributor

@anshulahuja98 @draghuram @ihcsim @Frank51 WDYT? In an attempt to keep downstream bugs out of upstream velero, we were thinking to link to downstream support in the troubleshooting guide. If you agree and have clearance to add a link perhaps post here.

@anshulahuja98
Copy link
Collaborator

@anshulahuja98 @draghuram @ihcsim @Frank51 WDYT? In an attempt to keep downstream bugs out of upstream velero, we were thinking to link to downstream support in the troubleshooting guide. If you agree and have clearance to add a link perhaps post here.

Hi
I think overall this makes sense for products which are OSS and using velero (ex. OADP). Where customer is truly aware that velero is the underlying engine and hence they might create issues here.
For our product, it is more of a managed solution, we don't expect customers to create any issues on github(we do not mention/ encourage the route)
Issues flow through MS Support and eventually reach us, then our engineering team follows up in community as required.

So far no customer of our product has created issues directly, and I don't expect that to change in near future.

Having said that, I don't have anything to add in terms of links for now.
We can evaluate in the future again if something changes for us in terms of support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants