-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MSI Support for Azure plugin. #6938
Conversation
4de800a
to
1897733
Compare
Codecov Report
@@ Coverage Diff @@
## main #6938 +/- ##
==========================================
+ Coverage 60.75% 60.77% +0.01%
==========================================
Files 250 250
Lines 26632 26639 +7
==========================================
+ Hits 16180 16189 +9
+ Misses 9302 9299 -3
- Partials 1150 1151 +1
|
1897733
to
a42938d
Compare
a42938d
to
7bb463e
Compare
@ywk253100 |
7bb463e
to
33c045a
Compare
@ywk253100 |
@yanggangtony do you have an environment to test this? Can you also make a PR for azure plugin consuming this, I'll pull the commit from your branch to test out in cluster. |
@anshulahuja98
Ok , i will go to the azure plugin repo , and found the call to consume that . There is seems some unit test wrong with |
@anshulahuja98 |
Ack |
Update: I tried to run some automated tests yesterday, but did some mistakes will try again today, and get back once done. |
thanks . |
Just completed validation, it is working as expected. |
ok , i will check it later. |
33c045a
to
27195a4
Compare
a81fa53
to
4ad957a
Compare
4ad957a
to
94cbc36
Compare
i will continue test.. |
Signed-off-by: yanggang <gang.yang@daocloud.io>
94cbc36
to
c8ffce8
Compare
interesting!! @anshulahuja98 |
the ci happy now.. |
@yanggangtony please update the azure PR as well with latest reference |
Ack |
Signed-off-by: yanggang <gang.yang@daocloud.io>
Thank you for contributing to Velero!
Please add a summary of your change
Add MSI Support for Azure plugin.
Does your change fix a particular issue?
Fixes #(#6931)
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.