-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency of the legacy client code from pkg/cmd directory part 1 #6469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackpiglet
changed the title
Remove dependency of the legacy client code.
Remove dependency of the legacy client code from pkg/cmd directory
Jul 6, 2023
Codecov Report
@@ Coverage Diff @@
## main #6469 +/- ##
==========================================
- Coverage 60.18% 60.15% -0.04%
==========================================
Files 229 229
Lines 24215 24226 +11
==========================================
- Hits 14575 14572 -3
- Misses 8632 8643 +11
- Partials 1008 1011 +3
|
blackpiglet
force-pushed
the
6190_fix
branch
5 times, most recently
from
July 7, 2023 09:00
a98bebb
to
dbd65d7
Compare
blackpiglet
changed the title
Remove dependency of the legacy client code from pkg/cmd directory
Remove dependency of the legacy client code from pkg/cmd directory part 1
Jul 7, 2023
9 tasks
blackpiglet
force-pushed
the
6190_fix
branch
3 times, most recently
from
July 11, 2023 08:59
c871066
to
6779436
Compare
ywk253100
reviewed
Jul 12, 2023
blackpiglet
force-pushed
the
6190_fix
branch
6 times, most recently
from
July 13, 2023 12:56
06624eb
to
ab3caa0
Compare
ywk253100
previously approved these changes
Jul 14, 2023
Signed-off-by: Xun Jiang <jxun@vmware.com>
ywk253100
approved these changes
Jul 14, 2023
Lyndon-Li
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #6190
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.