Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CRDs to list of prioritized resources #424

Closed
ncdc opened this issue Apr 12, 2018 · 2 comments · Fixed by #962
Closed

Add CRDs to list of prioritized resources #424

ncdc opened this issue Apr 12, 2018 · 2 comments · Fixed by #962
Labels
Enhancement/User End-User Enhancement to Velero Good first issue Looking to contribute to Velero? Issues with this label might be a great place to start! Help wanted
Milestone

Comments

@ncdc
Copy link
Contributor

ncdc commented Apr 12, 2018

User Story

As a cluster operator, I would like to use Ark to backup and restore my Kubernetes clusters which leverage Custom Resource Definitions.

As a Gimbal cluster operator, I would like to be able to use Ark to backup and restore my Gimbal cluster


We need to restore CRDs before we restore their associated CRs, so we need to add CRDs to the list of default resource priorities.

It would also be nice if we could wait for a CRD to be "ready" (as indicated in its status) before proceeding; otherwise, trying to create CRs for it might fail.

@skriss
Copy link
Contributor

skriss commented Apr 17, 2018

How exactly should "ready" be determined? Here's what I see in .status for the backup.ark.heptio.com CRD:

status:
  acceptedNames:
    kind: Backup
    listKind: BackupList
    plural: backups
    singular: backup
  conditions:
  - lastTransitionTime: 2018-04-17T18:07:24Z
    message: no conflicts found
    reason: NoConflicts
    status: "True"
    type: NamesAccepted
  - lastTransitionTime: 2018-04-17T18:07:24Z
    message: the initial names have been accepted
    reason: InitialNamesAccepted
    status: "True"
    type: Established

@ncdc
Copy link
Contributor Author

ncdc commented Apr 17, 2018

I think we need to key off of the Established condition.

@ncdc ncdc added this to the v1.0.0 milestone Jun 26, 2018
@ncdc ncdc added the Enhancement/User End-User Enhancement to Velero label Jun 26, 2018
@rosskukulinski rosskukulinski added Help wanted Good first issue Looking to contribute to Velero? Issues with this label might be a great place to start! labels Aug 8, 2018
@nrb nrb modified the milestones: v1.0.0, v0.10.0 Aug 28, 2018
domenicrosati added a commit to domenicrosati/ark that referenced this issue Oct 19, 2018
Signed-off-by: Domenic Rosati <domenicrosati@gmail.com>
domenicrosati added a commit to domenicrosati/ark that referenced this issue Oct 19, 2018
Signed-off-by: Domenic Rosati <domenicrosati@gmail.com>
@ncdc ncdc changed the title Add CRDs to list of prioritized resources & wait for them to be ready Add CRDs to list of prioritized resources Oct 19, 2018
@ncdc ncdc closed this as completed in #962 Oct 19, 2018
ncdc added a commit that referenced this issue Oct 19, 2018
Add CRDs to list of prioritized resources
wwitzel3 added a commit to wwitzel3/velero that referenced this issue Nov 1, 2018
Signed-off-by: Wayne Witzel III <wayne@riotousliving.com>
wwitzel3 added a commit to wwitzel3/velero that referenced this issue Nov 1, 2018
Signed-off-by: Wayne Witzel III <wayne@riotousliving.com>
@wwitzel3 wwitzel3 mentioned this issue Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement/User End-User Enhancement to Velero Good first issue Looking to contribute to Velero? Issues with this label might be a great place to start! Help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants