Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for injecting tolerations to sonobuoy pod #1973

Closed
masap opened this issue May 17, 2024 · 0 comments · Fixed by #1976
Closed

Add support for injecting tolerations to sonobuoy pod #1973

masap opened this issue May 17, 2024 · 0 comments · Fixed by #1976

Comments

@masap
Copy link
Contributor

masap commented May 17, 2024

Describe the solution you'd like
[A clear and concise description of what you want to happen.]
We can inject tolerations to plugin pods but can't inject to sonobuoy pod.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
I would like to specify Tolerations with sonobuoy run --confg=sonobuoy-config.json. sonobuoy-config.json contains Tolerations.

{
  "Tolerations": [
    {
      "Key": "node-role.kubernetes.io/master",
      "Operator": "Exists",
      "Effect": "NoSchedule"
    },
    {
      "Key": "CriticalAddonsOnly",
      "Operator": "Exists"
    },
    {
      "Key": "node-role.kubernetes.io/controlplane",
      "Operator": "Equal",
      "Value": "true",
      "Effect": "NoSchedule"
    }
  ]
 }

Environment:

  • Sonobuoy version:
  • Kubernetes version: (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
masap added a commit to masap/sonobuoy that referenced this issue Jun 18, 2024
@masap
Add support for injecting tolerations to sonobuoy pod
fbfc0f0 
Resolves vmware-tanzu#1973.

We can inject some tolerations to sonobuoy aggregator pod by adding trailing
description into sonobuoy config json.

{
  "AggregatorTolerations": [
    {
      "effect": "NoSchedule",
      "key": "key1",
      "operator": "Equal",
      "value": "value1"
    },
    {
      "effect": "NoSchedule",
      "key": "key2",
      "operator": "Equal",
      "value": "value2"
    }
  ]
}

Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
@masap masap mentioned this issue Jun 18, 2024
Merged
masap added a commit to masap/sonobuoy that referenced this issue Jun 19, 2024
@masap
Add support for injecting tolerations to sonobuoy pod
b22b04c 
Resolves vmware-tanzu#1973.

We can inject some tolerations to sonobuoy aggregator pod by adding trailing
description into sonobuoy config json.

{
  "AggregatorTolerations": [
    {
      "effect": "NoSchedule",
      "key": "key1",
      "operator": "Equal",
      "value": "value1"
    },
    {
      "effect": "NoSchedule",
      "key": "key2",
      "operator": "Equal",
      "value": "value2"
    }
  ]
}

Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
masap added a commit to masap/sonobuoy that referenced this issue Jun 28, 2024
@masap
Add support for injecting tolerations to sonobuoy pod
6ee72bf 
Resolves vmware-tanzu#1973.

We can inject some tolerations to sonobuoy aggregator pod by adding trailing
description into sonobuoy config json.

{
  "AggregatorTolerations": [
    {
      "effect": "NoSchedule",
      "key": "key1",
      "operator": "Equal",
      "value": "value1"
    },
    {
      "effect": "NoSchedule",
      "key": "key2",
      "operator": "Equal",
      "value": "value2"
    }
  ]
}

Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
masap added a commit to masap/sonobuoy that referenced this issue Jun 28, 2024
@masap
Add support for injecting tolerations to sonobuoy pod
978fd0a 
Resolves vmware-tanzu#1973.

We can inject some tolerations to sonobuoy aggregator pod by adding trailing
description into sonobuoy config json.

{
  "AggregatorTolerations": [
    {
      "effect": "NoSchedule",
      "key": "key1",
      "operator": "Equal",
      "value": "value1"
    },
    {
      "effect": "NoSchedule",
      "key": "key2",
      "operator": "Equal",
      "value": "value2"
    }
  ]
}

Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
masap added a commit to masap/sonobuoy that referenced this issue Jul 1, 2024
@masap
Add support for injecting tolerations to sonobuoy pod
7c8946b 
Resolves vmware-tanzu#1973.

We can inject some tolerations to sonobuoy aggregator pod by adding trailing
description into sonobuoy config json.

{
  "AggregatorTolerations": [
    {
      "effect": "NoSchedule",
      "key": "key1",
      "operator": "Equal",
      "value": "value1"
    },
    {
      "effect": "NoSchedule",
      "key": "key2",
      "operator": "Equal",
      "value": "value2"
    }
  ]
}

Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
masap added a commit to masap/sonobuoy that referenced this issue Jul 1, 2024
@masap
Add support for injecting tolerations to sonobuoy pod
91fb4a7 
Resolves vmware-tanzu#1973.

We can inject some tolerations to sonobuoy aggregator pod by adding trailing
description into sonobuoy config json.

{
  "AggregatorTolerations": [
    {
      "effect": "NoSchedule",
      "key": "key1",
      "operator": "Equal",
      "value": "value1"
    },
    {
      "effect": "NoSchedule",
      "key": "key2",
      "operator": "Equal",
      "value": "value2"
    }
  ]
}

Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
masap added a commit to masap/sonobuoy that referenced this issue Jul 1, 2024
@masap
Add support for injecting tolerations to sonobuoy pod
38b876f 
Resolves vmware-tanzu#1973.

We can inject some tolerations to sonobuoy aggregator pod by adding trailing
description into sonobuoy config json.

{
  "AggregatorTolerations": [
    {
      "effect": "NoSchedule",
      "key": "key1",
      "operator": "Equal",
      "value": "value1"
    },
    {
      "effect": "NoSchedule",
      "key": "key2",
      "operator": "Equal",
      "value": "value2"
    }
  ]
}

Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
masap added a commit to masap/sonobuoy that referenced this issue Jul 1, 2024
@masap
Add support for injecting tolerations to sonobuoy pod
5d7d17c 
Resolves vmware-tanzu#1973.

We can inject some tolerations to sonobuoy aggregator pod by adding trailing
description into sonobuoy config json.

{
  "AggregatorTolerations": [
    {
      "effect": "NoSchedule",
      "key": "key1",
      "operator": "Equal",
      "value": "value1"
    },
    {
      "effect": "NoSchedule",
      "key": "key2",
      "operator": "Equal",
      "value": "value2"
    }
  ]
}

Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
masap added a commit to masap/sonobuoy that referenced this issue Jul 1, 2024
@masap
Add support for injecting tolerations to sonobuoy pod
092c8f6 
Resolves vmware-tanzu#1973.

We can inject some tolerations to sonobuoy aggregator pod by adding trailing
description into sonobuoy config json.

{
  "AggregatorTolerations": [
    {
      "effect": "NoSchedule",
      "key": "key1",
      "operator": "Equal",
      "value": "value1"
    },
    {
      "effect": "NoSchedule",
      "key": "key2",
      "operator": "Equal",
      "value": "value2"
    }
  ]
}

Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
masap added a commit to masap/sonobuoy that referenced this issue Jul 1, 2024
@masap
Add support for injecting tolerations to sonobuoy pod
f0b70ae 
Resolves vmware-tanzu#1973.

We can inject some tolerations to sonobuoy aggregator pod by adding trailing
description into sonobuoy config json.

{
  "AggregatorTolerations": [
    {
      "effect": "NoSchedule",
      "key": "key1",
      "operator": "Equal",
      "value": "value1"
    },
    {
      "effect": "NoSchedule",
      "key": "key2",
      "operator": "Equal",
      "value": "value2"
    }
  ]
}

Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
masap added a commit to masap/sonobuoy that referenced this issue Jul 1, 2024
@masap
Add support for injecting tolerations to sonobuoy pod
aa5665c 
Resolves vmware-tanzu#1973.

We can inject some tolerations to sonobuoy aggregator pod by adding trailing
description into sonobuoy config json.

{
  "AggregatorTolerations": [
    {
      "effect": "NoSchedule",
      "key": "key1",
      "operator": "Equal",
      "value": "value1"
    },
    {
      "effect": "NoSchedule",
      "key": "key2",
      "operator": "Equal",
      "value": "value2"
    }
  ]
}

Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
masap added a commit to masap/sonobuoy that referenced this issue Jul 1, 2024
@masap
Add support for injecting tolerations to sonobuoy pod
64c05f4 
Resolves vmware-tanzu#1973.

We can inject some tolerations to sonobuoy aggregator pod by adding trailing
description into sonobuoy config json.

{
  "AggregatorTolerations": [
    {
      "effect": "NoSchedule",
      "key": "key1",
      "operator": "Equal",
      "value": "value1"
    },
    {
      "effect": "NoSchedule",
      "key": "key2",
      "operator": "Equal",
      "value": "value2"
    }
  ]
}

Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
masap added a commit to masap/sonobuoy that referenced this issue Jul 1, 2024
@masap
Add support for injecting tolerations to sonobuoy pod
9acc2df 
Resolves vmware-tanzu#1973.

We can inject some tolerations to sonobuoy aggregator pod by adding trailing
description into sonobuoy config json.

{
  "AggregatorTolerations": [
    {
      "effect": "NoSchedule",
      "key": "key1",
      "operator": "Equal",
      "value": "value1"
    },
    {
      "effect": "NoSchedule",
      "key": "key2",
      "operator": "Equal",
      "value": "value2"
    }
  ]
}

Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for injecting tolerations to sonobuoy pod masap/sonobuoy
1 participant
@masap