This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
owner/docs
Work executed by VMware documentation team
label
Jan 5, 2022
nrb
reviewed
Jan 6, 2022
garrying
reviewed
Jan 10, 2022
stmcginnis
force-pushed
the
visibility-proposal
branch
from
January 10, 2022 19:59
94a4049
to
3a2ca01
Compare
LGTM! |
nrb
reviewed
Jan 20, 2022
nrb
reviewed
Jan 20, 2022
joshrosso
reviewed
Jan 20, 2022
joshrosso
reviewed
Jan 20, 2022
jpmcb
reviewed
Jan 20, 2022
joshrosso
reviewed
Jan 20, 2022
jpmcb
reviewed
Jan 20, 2022
stmcginnis
commented
Jan 20, 2022
stmcginnis
force-pushed
the
visibility-proposal
branch
from
January 20, 2022 22:59
3a2ca01
to
4ba29c1
Compare
stmcginnis
force-pushed
the
visibility-proposal
branch
3 times, most recently
from
February 7, 2022 14:43
9d91217
to
1e4a0f9
Compare
joshrosso
reviewed
Feb 7, 2022
joshrosso
reviewed
Feb 7, 2022
joshrosso
reviewed
Feb 7, 2022
joshrosso
reviewed
Feb 7, 2022
stmcginnis
force-pushed
the
visibility-proposal
branch
from
February 7, 2022 16:27
1e4a0f9
to
70d9142
Compare
joshrosso
suggested changes
Feb 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stmcginnis once you address the linter issues, we're ready to approve/merge.
This adds a design document that goes into more detail for the proposed changes to make our bootstrap process more intuitive and easier to understand for our end users. Signed-off-by: Sean McGinnis <smcginnis@vmware.com>
stmcginnis
force-pushed
the
visibility-proposal
branch
from
February 9, 2022 16:19
70d9142
to
dce1d57
Compare
10 tasks
joshrosso
approved these changes
Mar 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This adds a design document that goes into more detail for the proposed
changes to make our bootstrap process more intuitive and easier to
understand for our end users.
Details for the Release Notes (PLEASE PROVIDE)
Which issue(s) this PR fixes
Fixes: #2730